Add Deserialize implementation to the ser feature. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses shssoichiro#74. This is a non-backward compatible change, as the commit changes `Pattern.sequence_name` and `RegexPattern.regex_name` from `&'static str` to `String` in order to avoid static bounds during deserialization.
shssoichiro
approved these changes
Feb 12, 2025
|
Indeed, the typing changes cannot be avoided. It is unfortunate, but I feel
like the impact is pretty limited.
…On Wed, 12 Feb 2025, 14.15 Josh Holmer, ***@***.***> wrote:
***@***.**** approved this pull request.
Sorry that it's taken so long to review this. I don't love the typing
change, but I suppose it's unavoidable... I'll go ahead and accept this.
Thanks!
—
Reply to this email directly, view it on GitHub
<#89 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAID4LENUCBT4VLUAASFXD2PNCPVAVCNFSM6AAAAABVOTQNYWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMJRHA4DEMZUGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #74.
This is a non-backward compatible change, as the commit changes
Pattern.sequence_nameandRegexPattern.regex_namefrom&'static strtoStringin order to avoid static bounds during deserialization.