Final Feedback (#21)

* Empty branch

* Simplify loop conditional

* Add quorum optimal helper to test

* Remove newlines

* Expand abbreviation:

* Change SubscriptionDetails field

* add common proposal validation method

* Change variable name in log

* Change variable name in log

* Add syntax sugar for transport multicasts

* Add simple start method for state

* Add log for invalid proposal

* Change naming of routine method

* Simplify block preprepare acceptance

* Add explainer for loop iteration

* Add to barrier before starting the routine

* Have the barrier increase right before the go routines

* Make the conditional for subscription pushes more clear

* Fix conditional for higher rounds

core/consensus_test.go

@@ -14,7 +14,7 @@ import (
 func generateNodeAddresses(count int) [][]byte {
 	addresses := make([][]byte, count)
 
-	for index := 0; index < count; index++ {
+	for index := range addresses {
 		addresses[index] = []byte(fmt.Sprintf("node %d", index))
 	}
 
@@ -291,16 +291,20 @@ func TestConsensus_InvalidBlock(t *testing.T) {
 		return uint64((nodeCount - 1) / 3)
 	}
 
+	quorumOptimal := func(numNodes int) uint64 {
+		if maxFaulty(numNodes) == 0 {
+			return uint64(numNodes)
+		}
+
+		return uint64(math.Ceil(2 * float64(numNodes) / 3))
+	}
+
 	// commonBackendCallback is the common method modification required
 	// for the Backend, for all nodes
 	commonBackendCallback := func(backend *mockBackend, nodeIndex int) {
 		// Make sure the quorum function is Quorum optimal
 		backend.quorumFn = func(_ uint64) uint64 {
-			if maxFaulty(numNodes) == 0 {
-				return uint64(numNodes)
-			}
-
-			return uint64(math.Ceil(2 * float64(numNodes) / 3))
+			return quorumOptimal(numNodes)
 		}
 
 		// Make sure the allowed faulty nodes function is accurate