Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling #1246

Merged
merged 28 commits into from
Dec 23, 2021
Merged

Spelling #1246

merged 28 commits into from
Dec 23, 2021

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Dec 23, 2021

Summary

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@b446970#commitcomment-62396680

The action reports that the changes in this PR would make it happy: jsoref@2872d9c

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

Ticket Link

Fixes

Release Note

NONE

jsoref added 12 commits December 23, 2021 04:09
@jsoref
spelling: abstractions
d4eb4f4 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: annotations
212f35b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: announcement
9a5de55 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: attached
cee3f67 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: attachment
7a313a5 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: attestation
ccd881f 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: cloudbuild
91a1d9c 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: compatibility
992c55e 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: consideration
5bb965a 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: constituent
75d7a44 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: dekkagaijin
c724ee3 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: dependabot
c8cda62 
Signed-off-by: Josh Soref <[email protected]>
cpanato
cpanato reviewed Dec 23, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me thanks for that
i would say to squash the commits in one
and I vote to add this action as well

@cpanato cpanato requested review from mattmoor and dlorenc December 23, 2021 10:04
jsoref
jsoref commented Dec 23, 2021
View reviewed changes
Copy link
Contributor Author

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most corrections were automatically suggested by Google Sheets.

I added a couple of manual fixes (mostly brands and a name) and a couple of overrides.

All blame goes to me

CHANGELOG.md
@@ -46,7 +46,7 @@ A whole buncha bugfixes!
* Added the `--signature-digest-algorithm` flag to `cosign verify`, allowing verification of container image signatures which were generated with a non-SHA256 signature algorithm (https://github.com/sigstore/cosign/pull/1071)
* Builds should now be reproducible (https://github.com/sigstore/cosign/pull/1053)
* Allows base64 files as `--cert` in `cosign verify-blob` (https://github.com/sigstore/cosign/pull/1088)
* Kubernetes secrets generated for version >= 1.21 clusters have the immutible bit set (https://github.com/sigstore/cosign/pull/1091)
* Kubernetes secrets generated for version >= 1.21 clusters have the immutable bit set (https://github.com/sigstore/cosign/pull/1091)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some projects don't like retroactive changes to release notes, let me know if you want me to drop all changes to this (or any other) file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see an issue with it!

CHANGELOG.md
@@ -134,7 +134,7 @@ A whole buncha bugfixes!
* `manifest verify` now supports verifying images in all Kubernetes objects that fit within `PodSpec`, `PodSpecTemplate`, or `JobSpecTemplate`, including CRDs (https://github.com/sigstore/cosign/pull/697)
* Added shell auto-completion support (Clutch collab from @erkanzileli, @passcod, and @Dentrax! https://github.com/sigstore/cosign/pull/836)
* `cosign` has generated Markdown docs available in the `doc/` directory (https://github.com/sigstore/cosign/pull/839)
* Added support for verifying with secrets from a Gitlab project (https://github.com/sigstore/cosign/pull/934)
* Added support for verifying with secrets from a GitLab project (https://github.com/sigstore/cosign/pull/934)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brand

CHANGELOG.md
@@ -412,7 +412,7 @@ See [#254](https://github.com/sigstore/cosign/issues/254) for more info.
* Dan Lorenc
* Priya Wadhwa
* Ivan Font
* Depandabot!
* Dependabot!
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brand

CODEOWNERS
@@ -4,7 +4,7 @@

# asraa
# bobcallaway
# dekakgaijin
# dekkagaijin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dekkagaijin

KEYLESS.md
@@ -66,7 +66,7 @@ These can be supplied on the command line with the `--identity-token` flag.
The `audiences` field must contain `sigstore`.

`cosign` also has support for detecting some of these automated environments
and producing an identity token. Currently this supports Google and Github.
and producing an identity token. Currently this supports Google and GitHub.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brand

pkg/cosign/tuf/policy_test.go
@@ -55,7 +55,7 @@ func TestValidKey(t *testing.T) {
t.Errorf("Error adding public key")
}
if _, err := root.ValidKey(publicKey, "root"); err != nil {
t.Errorf("Error checking key validit %s", err)
t.Errorf("Error checking key validity %s", err)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

pkg/oci/remote/remote.go
type attache struct {
type attached struct {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be tempted to use attachment but I didn't want to have to figure out if golang would scream at me.

I'm not entirely certain what this object is.

specs/COSIGN_PREDICATE_SPEC.md
@@ -7,7 +7,7 @@ doesn't fit well into other types.
The format for this is defined as follows:

`data`: Raw data to place in the attestation. This is a base64-encoded string of bytes.
`timestamp`: The timestamp the attestion was generated at in the RFC3339 format in the UTC timezone.
`timestamp`: The timestamp the attestation was generated at in the RFC3339 format in the UTC timezone.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user facing doc

specs/SBOM_SPEC.md
"annotatons": {
"annotations": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad example?

dlorenc
dlorenc reviewed Dec 23, 2021
View reviewed changes
Copy link
Member

@dlorenc dlorenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one nit about digest-able, otherwise this lgtm!

jsoref added 13 commits December 23, 2021 09:10
@jsoref
spelling: environment
69f111f 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: github
f2ad159 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: gitlab
2dce82d 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: immutable
6c2039b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: include
03a92f8 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: initialized
637a98b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: mailing
20e1d54 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: payloads
0d93b05 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: percent
242fa9d 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: setting
4ba95f6 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: sigstore
601e152 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: stored
c2f546b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: validity
b512f3e 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: verified
0b980e3 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: verifier
97720db 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: without
cdc5711 
Signed-off-by: Josh Soref <[email protected]>
@dlorenc dlorenc merged commit 4e4bbf6 into sigstore:main Dec 23, 2021
@github-actions github-actions bot added this to the v1.5.0 milestone Dec 23, 2021
@jsoref jsoref deleted the spelling branch December 23, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato left review comments

@dlorenc dlorenc dlorenc approved these changes

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoref @dlorenc @cpanato