Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved certificate output before checking for upload during signing #1255

Merged
merged 1 commit into from
Dec 27, 2021

Conversation

sabre1041
Copy link
Contributor

Moved logic to print certificate during signing earlier on otherwise logic is not reached when --upload=false

@dlorenc
Copy link
Member

dlorenc commented Dec 27, 2021

GitHub is struggling today.

@sabre1041
Copy link
Contributor Author

sabre1041 commented Dec 27, 2021

@dlorenc github must have the holiday hangover :)

@dlorenc dlorenc merged commit dfc0347 into sigstore:main Dec 27, 2021
@github-actions github-actions bot added this to the v1.5.0 milestone Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants