Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt user before running cosign clean #1649

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

priyawadhwa
Copy link
Contributor

Signed-off-by: Priya Wadhwa [email protected]

fixes #1452

Prompt user before running `cosign clean`

@codecov-commenter
Copy link

Codecov Report

Merging #1649 (7a82b14) into main (b102404) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1649      +/-   ##
==========================================
- Coverage   27.89%   27.84%   -0.06%     
==========================================
  Files         139      139              
  Lines        7972     7987      +15     
==========================================
  Hits         2224     2224              
- Misses       5512     5527      +15     
  Partials      236      236              
Impacted Files Coverage Δ
cmd/cosign/cli/clean.go 0.00% <0.00%> (ø)
pkg/cosign/common.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b102404...7a82b14. Read the comment docs.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@dlorenc
Copy link
Member

dlorenc commented Mar 23, 2022

Two quick nits

Signed-off-by: Priya Wadhwa <[email protected]>
@priyawadhwa priyawadhwa merged commit bdef009 into sigstore:main Mar 23, 2022
@priyawadhwa priyawadhwa deleted the prompt-user branch March 23, 2022 19:48
@github-actions github-actions bot added this to the v1.7.0 milestone Mar 23, 2022
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
* Prompt user before running `cosign clean`

Signed-off-by: Priya Wadhwa <[email protected]>

* Add force flag for clean

Signed-off-by: Priya Wadhwa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit cosign output
4 participants