-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace gcr.io/distroless/ to use ghcr.io/distroless/ #1961
Conversation
Signed-off-by: cpanato <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1961 +/- ##
=======================================
Coverage 34.71% 34.71%
=======================================
Files 153 153
Lines 10037 10037
=======================================
Hits 3484 3484
Misses 6166 6166
Partials 387 387 Continue to review full report at Codecov.
|
Signed-off-by: cpanato <[email protected]>
8ce68f3
to
be447aa
Compare
Signed-off-by: cpanato <[email protected]>
be447aa
to
ceae8d5
Compare
Signed-off-by: cpanato <[email protected]>
For context, the gcr images are great but regularly have CI issues that prevent new builds from being fully signed. We've seen this 3-4 times now. The builds aren't viewable or debuggable by people outside the org either. We only actually use these images in tests, so this is just switching them to another image with a simpler build and test process that's debuggable by the community. |
Merging to unblock things. We can revisit later if there's a better choice for these tests. |
FWIW we've probably seen this dozens of times, it is just usually transient. I filed this, which hasn't seen much traction: GoogleContainerTools/distroless#966 We are very intentional about promoting to |
Summary
the images from gcr.io/distroless/ (https://github.com/GoogleContainerTools/distroless) are having issues with the signatures and then it is failing our tests, switching to images that we can have a bit more control (https://github.com/distroless/) and act fast in case of any issue.
for building images need a few more tests to check if everything will work as usual
Ticket Link
N/A
Release Note