update to go 1.18 #2059
Merged
update to go 1.18 #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorj2f
previously approved these changes
Jul 11, 2022
|
Failing because go get isn't supported outside a module and the codegen scripts do this. working on it. |
|
had to update knative.dev/hack to support go 1.18. an old version used go get, and that's no longer supported outside a module. edit: |
Signed-off-by: Asra Ali <[email protected]> update Signed-off-by: Asra Ali <[email protected]> also update Signed-off-by: Asra Ali <[email protected]>
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali [email protected]
Summary
This is a pre-requisite to updating rekor.
Locally, ./hack/update-codegen.sh doesn't complete successfully for me, so this may not pass CI on the first run.
Release Note
Documentation