Use OCI Image Manifest v1 #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @jonjohnsonjr |
|
@jonjohnsonjr any guesses how/where this might not work? GCR is happy |
jonjohnsonjr
reviewed
May 4, 2021
dekkagaijin
force-pushed
the
oci
branch
5 times, most recently
from
254fe7f to
69b429d
Compare
dlorenc
reviewed
May 4, 2021
|
One nit, a one-line integration test of the legacy env var here would be good too: https://github.com/sigstore/cosign/blob/main/test/e2e_test_secrets.sh#L55 |
dekkagaijin
force-pushed
the
oci
branch
2 times, most recently
from
faabe9f to
91f7625
Compare
jonjohnsonjr
reviewed
May 4, 2021
| // should never happen...? | ||
| return nil, err | ||
| } | ||
| m.Config.MediaType = types.OCIConfigJSON |
There was a problem hiding this comment.
Oh that's interesting. I don't think we intended for that return value to be mutable, but I guess it is...
cc @imjasonh I would consider this a bug.
There was a problem hiding this comment.
let us have our fun :p
I will not be contained!
done |
dlorenc
approved these changes
May 4, 2021
Signed-off-by: Jake Sanders <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #250
Signed-off-by: Jake Sanders [email protected]