Allow custom root PEM #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 26, 2021 14:45
This change allows use of a custom env `COSIGN_ROOT` for those who wish to use their own root CA in an off public net fulcio instance. Ultimately we might want to do this with a flag, but it requires a fair amount of rewrite, so this seems a good pragamtic bridge without being to disruptive prior to 1.0 Signed-off-by: Luke Hinds <[email protected]>
Signed-off-by: Luke Hinds <[email protected]>
dlorenc
reviewed
Jul 26, 2021
pkg/cosign/fulcio/fulcio.go
Outdated
| @@ -46,6 +47,7 @@ const ( | |||
| FlowNormal = "normal" | |||
| FlowDevice = "device" | |||
| FlowToken = "token" | |||
| altRoot = "COSIGN_ROOT" | |||
There was a problem hiding this comment.
nit: maybe "SIGSTORE_ROOT_DIR" instead? These are really the roots for the sigstore project and aren't cosign specific.
There was a problem hiding this comment.
agree on both, I will add the other flags added too.
Signed-off-by: Luke Hinds <[email protected]>
dlorenc
reviewed
Jul 26, 2021
added 2 commits
July 26, 2021 18:11
Signed-off-by: Luke Hinds <[email protected]>
Signed-off-by: Luke Hinds <[email protected]>
dlorenc
approved these changes
Jul 27, 2021
Signed-off-by: Luke Hinds <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows use of a custom env
COSIGN_ROOTfor thosewho wish to use their own root CA in an off public net fulcio
instance.
Ultimately we might want to do this with a flag, but it requires
a fair amount of rewrite, so this seems a good pragamtic bridge
without being to disruptive prior to 1.0
Resolves: #87
Signed-off-by: Luke Hinds [email protected]