Add sget to the release artifacts
#745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgreinho
force-pushed
the
issues725/sget-release
branch
from
38ca57f to
f515323
Compare
|
cool, thanks @rgreinho! @dlorenc @dekkagaijin I will update the release pipeline to include this in the release as well ok? |
cpanato
requested changes
Sep 22, 2021
rgreinho
force-pushed
the
issues725/sget-release
branch
from
8e0b80b to
9e0bcc5
Compare
During the release process, builds `sget` along cosign, signs, verifies and publishes the binaries. Fixes sigstore#725 Signed-off-by: Rémy Greinhofer <[email protected]>
rgreinho
force-pushed
the
issues725/sget-release
branch
from
9e0bcc5 to
d253ab8
Compare
dlorenc
approved these changes
Sep 22, 2021
|
@cpanato it looks like your comment was addressed. Merge if you're happy! |
|
I'm always happy :) |
rgreinho
added a commit
to rgreinho/cosign
that referenced
this pull request
Sep 23, 2021
After pushing sigstore#745, the signing/verifying mechamnism for the created binaries was broken. This patch fixes the issue and removes the useless duplication, making the CI workflow DRYer.
Merged
rgreinho
added a commit
to rgreinho/cosign
that referenced
this pull request
Sep 23, 2021
After pushing sigstore#745, the signing/verifying mechanism for the created binaries was broken. This patch fixes the issue and removes the useless duplication, making the CI workflow DRYer.
rgreinho
added a commit
to rgreinho/cosign
that referenced
this pull request
Sep 23, 2021
After pushing sigstore#745, the signing/verifying mechanism for the created binaries was broken. This patch fixes the issue and removes the useless duplication, making the CI workflow DRYer. Signed-off-by: Rémy Greinhofer <[email protected]>
dlorenc
pushed a commit
that referenced
this pull request
Sep 23, 2021
After pushing #745, the signing/verifying mechanism for the created binaries was broken. This patch fixes the issue and removes the useless duplication, making the CI workflow DRYer. Signed-off-by: Rémy Greinhofer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the release process, builds
sgetalong cosign, signs, verifiesand publishes the binaries.
Fixes #725