[#186] Ruff linting and formatting within Bazel

Makefile

@@ -53,7 +53,15 @@ bazel:
 	@bash ./src/scripts/bazel.sh $(filter-out $@, $(MAKECMDGOALS))
 
 test-all: build-image
-	$(MAKE) bazel test //...
+	@$(MAKE) bazel test //...
+
+lint-all:
+	@$(MAKE) bazel lint \
+		"//... --fix --report --diff" \
+		| grep -vE "(Lint results|All checks passed|^[[:blank:]]*$$)"
+
+format-all:
+	@$(MAKE) bazel run format
 
 # Catch-all pattern to prevent make from complaining about unknown targets
 %:

src/.aspect/cli/config.yaml

@@ -0,0 +1,3 @@
+lint:
+  aspects:
+    - //tools/lint:linters.bzl%ruff

src/.bazeliskrc

@@ -0,0 +1,2 @@
+BAZELISK_BASE_URL=https://github.com/aspect-build/aspect-cli/releases/download
+USE_BAZEL_VERSION=aspect/2024.49.18

src/.bazelrc

@@ -20,10 +20,16 @@ common --enable_bzlmod
 # localy
 build --spawn_strategy=local
 
+# Define versions
+build --define=ATOMDB_VERSION=0.8.11
+build --define=DAS_VERSION=0.9.17
+build --define=DAS_NODE_VERSION=0.0.1
+
 # Enable debugging symbols for development
 build:debug --compilation_mode=dbg
 build:debug --strip=never
 
+
 # Optimeze for speed in production
 build:release --compilation_mode=opt
 build:release --strip=always
@@ -40,6 +46,7 @@ test --flaky_test_attempts=1
 test --cache_test_results=auto
 test --test_env=BAZEL_TEST_ENV=1
 test --test_tag_filters=-skip
+test --notest_keep_going
 
 #################################### RUN ######################################
 

src/.ruff.toml

@@ -0,0 +1,36 @@
+line-length = 100
+indent-width = 4
+
+target-version = "py310"
+
+[lint]
+
+select = ["E4", "E7", "E9", "F", "B"]
+ignore = ["E501", "B905"]
+fixable = ["ALL"]
+unfixable = ["B"]
+
+
+# Allow unused variables when underscore-prefixed.
+dummy-variable-rgx = "^(_+|(_+[a-zA-Z0-9_]*[a-zA-Z0-9]+?))$"
+
+
+# Ignore `E402` (import violations) in all `__init__.py` files.
+[lint.per-file-ignores]
+"__init__.py" = ["E402", "F403"]
+"**/{tests,docs,tools}/*" = ["B006", "B011", "B017", "B018"]
+# Auto generated code
+"**/grpc/*.py" = ["ALL"]
+
+[format]
+quote-style = "double"
+
+indent-style = "space"
+
+skip-magic-trailing-comma = false
+
+line-ending = "auto"
+
+# Enable auto-formatting of code examples in docstrings
+docstring-code-format = true
+docstring-code-line-length = "dynamic"

src/BUILD

@@ -1,5 +1,22 @@
 package(default_visibility = ["//visibility:public"])
 
+exports_files(
+    [
+        ".ruff.toml",
+    ],
+    visibility = ["//visibility:public"],
+)
+
+alias(
+  name = "format.check",
+  actual = "//tools/format:format.check"
+)
+
+alias(
+  name = "format",
+  actual = "//tools/format"
+)
+
 cc_binary(
     name = "attention_broker_service",
     srcs = [],

src/MODULE.bazel

@@ -16,6 +16,8 @@ Additionally, this file configures:
 
 module(name = "das")
 
+# Bazel to run linters and formatters
+bazel_dep(name = "aspect_rules_lint", version = "1.2.0")
 
 # C++
 

src/hyperon_das/__init__.py

@@ -1,10 +1,10 @@
 import sys
 
 if sys.version_info < (3, 10):
-    raise RuntimeError('hyperon_das requires Python 3.10 or higher')
+    raise RuntimeError("hyperon_das requires Python 3.10 or higher")
 
 from hyperon_das.das import DistributedAtomSpace
 
-__all__ = ['DistributedAtomSpace']
+__all__ = ["DistributedAtomSpace"]
 
-__version__ = '0.9.14'
+__version__ = "0.9.14"

src/hyperon_das/cache/attention_broker_gateway.py

@@ -19,11 +19,11 @@ def __init__(self, system_parameters: Dict[str, Any]):
                     f"Invalid system parameters. server_hostname: '{self.server_hostname}' server_port: {self.server_port}"
                 )
             )
-        self.server_url = f'{self.server_hostname}:{self.server_port}'
+        self.server_url = f"{self.server_hostname}:{self.server_port}"
         self.ping()
 
     def ping(self) -> Optional[str]:
-        logger().info(f'Pinging AttentionBroker at {self.server_url}')
+        logger().info(f"Pinging AttentionBroker at {self.server_url}")
         with grpc.insecure_channel(self.server_url) as channel:
             stub = AttentionBrokerStub(channel)
             response = stub.ping(grpc_types.Empty())
@@ -33,9 +33,9 @@ def ping(self) -> Optional[str]:
 
     def stimulate(self, handle_count: Set[str]) -> Optional[str]:
         if handle_count is None:
-            das_error(ValueError(f'Invalid handle_count {handle_count}'))
+            das_error(ValueError(f"Invalid handle_count {handle_count}"))
         logger().info(
-            f'Requesting AttentionBroker at {self.server_url} to stimulate {len(handle_count)} atoms'
+            f"Requesting AttentionBroker at {self.server_url} to stimulate {len(handle_count)} atoms"
         )
         message = grpc_types.HandleCount(handle_count=handle_count)
         with grpc.insecure_channel(self.server_url) as channel:
@@ -47,9 +47,9 @@ def stimulate(self, handle_count: Set[str]) -> Optional[str]:
 
     def correlate(self, handle_set: Set[str]) -> Optional[str]:
         if handle_set is None:
-            das_error(ValueError(f'Invalid handle_set {handle_set}'))
+            das_error(ValueError(f"Invalid handle_set {handle_set}"))
         logger().info(
-            f'Requesting AttentionBroker at {self.server_url} to correlate {len(handle_set)} atoms'
+            f"Requesting AttentionBroker at {self.server_url} to correlate {len(handle_set)} atoms"
         )
         message = grpc_types.HandleList(handle_list=handle_set)
         sleep(0.05)