-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added sdk testcases, org metadata changes ,fixed some bugs #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
group is now moved to org level ALso add metadata-provider capablity
…un functional test,fixed some bugs as well
raamb
reviewed
Nov 29, 2019
raamb
reviewed
Nov 29, 2019
packages/sdk/snet/sdk/metadata_provider/ipfs_metadata_provider.py
Outdated
Show resolved
Hide resolved
raamb
reviewed
Nov 29, 2019
packages/sdk/snet/sdk/metadata_provider/ipfs_metadata_provider.py
Outdated
Show resolved
Hide resolved
raamb
reviewed
Nov 29, 2019
raamb
reviewed
Nov 29, 2019
raamb
reviewed
Nov 29, 2019
raamb
reviewed
Nov 29, 2019
raamb
reviewed
Nov 29, 2019
raamb
reviewed
Nov 29, 2019
raamb
reviewed
Nov 29, 2019
raamb
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added functional test cases
Setup environment with ipfs,blockchain,daemon,example service and run test cases.
Added changes related to org metadata, as group info has moved from service to organization
Now in sdk group will contain combined info from service and org.
Right now environment is setup with fixed version of snet-daemon , will change it to build from master branch in next iteration.