Generate fallback URLs for web archive links #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes logic that tries to find an existing snapshot through the web archive CDX API as a fallback when creating a new snapshot fails, or when importing bookmarks that have been added some time ago. The API's rate limit is hard to work around with the current architecture and causes issues with snapshot tasks being queued for a long time.
Instead, generate a fallback URL from the bookmark's URL and added timestamp. That should automatically display the nearest snapshot for that timestamp. Worst case a website might not have any snapshot, in which case the URL would be invalid.
Fixes #747