build: added build script

[kayrus]

Build script should build skydns on any host which has go 1.5+ binary.
Also added scripts/updatedep script which updates vendor dependencies using glide.

[miekg]

sorry, I'm just not a fan of all this vendoring....

[kayrus]

@miekg it actually helps users to build go apps without downloading dependencies every time. also it pins package versions. I had to spend quite a lot of time to configure/get all these dependencies until I was able to build a skydns binary.

[kayrus]

@miekg updated commit, added test script and fixed tests.

[miekg]

Sorry, but I'm not ready to vendor and then having to update all these
every so often.

I'm also not sure why a build script is needed and why go get is
insufficient....?

On 22 Aug 2016 10:18 pm, "kayrus" [email protected] wrote:

@miekg https://github.com/miekg updated commit, added test script and
fixed tests.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#293 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVkW0wMU7977Ca58kXuyOsS_-RBLugWks5qihILgaJpZM4Jpymr
.

[kayrus]

@miekg

1. try to build your app on fresh OS which only has go binaries and nothing more.
2. try to build it when there are also several apps with default GOPATH which would like to add cross-referenced deps of different versions.

[miekg]

Just did:

% cd g/src/github.com/miekg
% git clone [email protected]:skynetservices/skydns
% go get -u
% go build
% ./skydns -version
skydns server version: 2.5.3a

I'm not ready to start vendoring as I'm then forced to update them every so often. Yes the downside is that the build can and will break.

[kayrus]

@miekg you already have a GOPATH and a structure of GOROOT. I told you about "clean" machine. I.e. Clean cloud image of ubuntu xenial:

$ sudo apt-get install golang -y
$ git clone https://github.com/skynetservices/skydns
$ cd skydns
$ go get -u
package _/home/ubuntu/skydns: unrecognized import path "_/home/ubuntu/skydns" (import path does not begin with hostname)
$ go build
main.go:25:2: cannot find package "github.com/coreos/etcd/client" in any of:
        /usr/lib/go-1.6/src/github.com/coreos/etcd/client (from $GOROOT)
        ($GOPATH not set)
main.go:26:2: cannot find package "github.com/coreos/etcd/pkg/transport" in any of:
        /usr/lib/go-1.6/src/github.com/coreos/etcd/pkg/transport (from $GOROOT)
        ($GOPATH not set)
main.go:27:2: cannot find package "github.com/miekg/dns" in any of:
        /usr/lib/go-1.6/src/github.com/miekg/dns (from $GOROOT)
        ($GOPATH not set)
main.go:20:2: cannot find package "github.com/skynetservices/skydns/backends/etcd" in any of:
        /usr/lib/go-1.6/src/github.com/skynetservices/skydns/backends/etcd (from $GOROOT)
        ($GOPATH not set)
main.go:21:2: cannot find package "github.com/skynetservices/skydns/metrics" in any of:
        /usr/lib/go-1.6/src/github.com/skynetservices/skydns/metrics (from $GOROOT)
        ($GOPATH not set)
main.go:22:2: cannot find package "github.com/skynetservices/skydns/msg" in any of:
        /usr/lib/go-1.6/src/github.com/skynetservices/skydns/msg (from $GOROOT)
        ($GOPATH not set)
main.go:23:2: cannot find package "github.com/skynetservices/skydns/server" in any of:
        /usr/lib/go-1.6/src/github.com/skynetservices/skydns/server (from $GOROOT)
        ($GOPATH not set)
main.go:28:2: cannot find package "golang.org/x/net/context" in any of:
        /usr/lib/go-1.6/src/golang.org/x/net/context (from $GOROOT)
        ($GOPATH not set)

Here is my branch with the build script:

$ ./scripts/build
$ ./skydns --version
skydns server version: 2.5.3a

[miekg]

[ Quoting [email protected] in "Re: [skynetservices/skydns] build: ..." ]

@miekg you already have a GOPATH and a structure of GOROOT. I told you about "clean" machine. I.e. Clean cloud image of ubuntu xenial:

Ack, but I don't want to maintain such a script. This is more akin to setting up
Go from scratch (with a nudge to SkyDNS), then really something SkyDNS specific

[kayrus]

@miekg well, I don't know what can I say. Just imagine opensource world without make or cmake...

[mischief]

+1 for this.

if you don't wish to vendor the dependencies, at least use https://github.com/Masterminds/glide to create a version lockfile for the dependencies.

this way, it makes packaging easy because all dependencies and their versions can be listed in one place.

[miekg]

[ Quoting [email protected] in "Re: [skynetservices/skydns] build: ..." ]

+1 for this.

if you don't wish to vendor the dependencies, at least use https://github.com/Masterminds/glide to create a version lockfile for the dependencies.

That's one of the first not bat-shit-crazy vendoring tools I've come across.

this way, it makes packaging easy because all dependencies and their versions can be listed in one place.

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#293 (comment)
/Miek

Miek Gieben

[mountkin]

go get is broken on the master branch.

# github.com/coreos/etcd/clientv3
src/github.com/coreos/etcd/clientv3/client.go:344: cannot use c.tokenCred (type *authTokenCredential) as type credentials.PerRPCCredentials in argument to grpc.WithPerRPCCredentials:
	*authTokenCredential does not implement credentials.PerRPCCredentials (wrong type for GetRequestMetadata method)
		have GetRequestMetadata("context".Context, ...string) (map[string]string, error)
		want GetRequestMetadata("golang.org/x/net/context".Context, ...string) (map[string]string, error)
src/github.com/coreos/etcd/clientv3/client.go:400: cannot use client.balancer (type *healthBalancer) as type grpc.Balancer in argument to grpc.WithBalancer:
	*healthBalancer does not implement grpc.Balancer (wrong type for Get method)
		have Get("context".Context, grpc.BalancerGetOptions) (grpc.Address, func(), error)
		want Get("golang.org/x/net/context".Context, grpc.BalancerGetOptions) (grpc.Address, func(), error)
src/github.com/coreos/etcd/clientv3/retry.go:117: cannot use *retryKVClient literal (type *retryKVClient) as type etcdserverpb.KVClient in return argument:
	*retryKVClient does not implement etcdserverpb.KVClient (wrong type for Compact method)
		have Compact("context".Context, *etcdserverpb.CompactionRequest, ...grpc.CallOption) (*etcdserverpb.CompactionResponse, error)

[miekg]

Note that CoreDNS (coredns.io) should be able to give you a similar experience to SkyDNS and it waaay more actively maintained.