-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a bind mount from host to /usr/share/stormond/ directory on pmon container #18122
Merged
lguohan
merged 11 commits into
sonic-net:master
from
assrinivasan:bindmount-storagemond
May 18, 2024
Merged
Adds a bind mount from host to /usr/share/stormond/ directory on pmon container #18122
lguohan
merged 11 commits into
sonic-net:master
from
assrinivasan:bindmount-storagemond
May 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiarcot895
reviewed
Mar 27, 2024
saiarcot895
reviewed
Apr 2, 2024
saiarcot895
approved these changes
Apr 9, 2024
/azp run |
Commenter does not have sufficient privileges for PR 18122 in repo sonic-net/sonic-buildimage |
saiarcot895
reviewed
May 15, 2024
saiarcot895
approved these changes
May 15, 2024
@assrinivasan please point to the HLD in the PR descripton |
Done. |
prgeor
previously approved these changes
May 16, 2024
@lguohan please help merge |
/azpw ms_conflict |
1 similar comment
/azpw ms_conflict |
@saiarcot895 @prgeor I'm not sure why we are seeing an ms_conflict issue. I have verified that the three files I am changing here do not have any conflicts with the corresponding internal repo files. |
/azpw ms_conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
This is a part of a larger commit that adds a storage monitoring daemon to SONiC. This commit is needed to that storagemon daemon can save FS stats JSON file to disk in the event of planned reboots and unintentional powercycles.
SONiC Storage Monitoring Daemon HLD
Also added
psutil
module to perform process and system monitoring operations pythonically.Work item tracking
How I did it
How to verify it
Flash a switch with image containing the changes.
Run:
and verify the following parameters in the "mounts" section:
Additionally, you can run the following steps:
cat
the file on the host and verify that the text you added is seen hereAs a third test:
Run
ls -alirth
in both the/host/pmon/stormond
dir on the host and/usr/share/stormond
dir in the pmon container and verify that the inode numbers match.Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
adds bind mount from
/host/pmon/stormond
on the host to/usr/share/stormond
on the pmon container as part of the larger stormon daemon feature.Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)