Remove Duplicates in topsort results #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faraazbrcm
force-pushed
the
cvl_topo_result_fix
branch
from
80bec4a to
dc0452b
Compare
When LISTs were convered back to tables, there is a possibility of having consective duplicate table names in the result if there exists a dependency between table lists. Added a mechanism to remove such entries. Also resolved formatting issues in tranformer and CVL to adhere to bookworm environment(golang 1.19)
faraazbrcm
force-pushed
the
cvl_topo_result_fix
branch
from
dc0452b to
e0ecd1d
Compare
amrutasali
approved these changes
Jan 17, 2024
anand-kumar-subramanian
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When LISTs were converted back to tables, there is a possibility of having consecutive duplicate table names in the result if there exists a dependency between table lists. Added a mechanism to remove such entries. More comments in the code for the next steps