Service validator vul #3717
Open
Service validator vul #3717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
maipbui
reviewed
Mar 7, 2025
| def _service_restart(svc_name): | ||
| rc = os.system(f"systemctl restart {svc_name}") | ||
| rc = run_command(['systemctl', 'restart', svc_name]) |
There was a problem hiding this comment.
I think simply replace os.system with subprocess.call, as suggested in python doc https://docs.python.org/3/library/subprocess.html#replacing-os-system, no need to introduce new function run_command
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mohmamedali
force-pushed
the
service_validator_vul
branch
from
43c0b2d to
59956dc
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
maipbui
approved these changes
Mar 11, 2025
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
"os.system()" uses shell invocation to execute command which is dangerous. without a static string that can lead to command injection.
How I did it
pass use list of strings to subprocess() - use shell=False instead.
How to verify it
pass UT
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)