TestRepository_UpdateEverything includes "origin/" prefix on some Git versions

[sqs]

--- FAIL: TestRepository_UpdateEverything (0.92s)
    repository_test.go:1734: git: got UpdateResult == {
          "Changes": [
            {
              "Op": 1,
              "Branch": "master"
            },
            {
              "Op": 0,
              "Branch": "second"
            }
          ]
        }, want {
          "Changes": [
            {
              "Op": 1,
              "Branch": "origin/master"
            },
            {
              "Op": 0,
              "Branch": "second"
            }
          ]
        }

@shurcooL and @shazow report that the test passes for them; it fails for me on Linux git 2.7.0.rc0.20.g4b9ab0e and in the included Dockerfile test runner (Ubuntu 12.04 standard git version).

The desired behavior is to have no "origin/" prefix, but we need to strip the name of the remote in general (even if it is not named "origin").

[sqs]

I am going to update it to omit the "origin/" prefix in the test expectation, so that Travis CI passes. I will also add a comment if the test fails on this portion. Therefore the test above should no longer fail on Travis CI, but it may fail on @shurcooL's and @shazow's machines (and others like those).

[shazow]

FWIW it was not passing on my machine with the origin prefix.

See this discussion: 454a3d5#commitcomment-14943981

+1 to this change. I agree that this part of functionality should not require any knowledge of remotes.

[dmitshur]

Ah, that's where that discussion was. I was trying to find it and share with @sqs but couldn't. I thought it was on Slack. Thanks @shazow.