Fix CI. #103
Merged
Fix CI. #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove make test target, move it directly into .travis.yml. It's more readable and easier to do go test ./... than to read Makefile and see that make test does the same thing. Remove 1.4 target because it's very old. Remove machinery to move the repository into the right place in GOPATH; this can be replaced by the (relatively) new go_import_path Travis option.
go test runs a subset of vet and needs these issues to be fixed. Modern version of ssh package errors if HostKeyCallback is not specified.
This should allow the working git tests to produce a green CI status, until the hg implementation is restored. Updates #104.
keegancsmith
approved these changes
Apr 16, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes CI by updating travis config, by dropping Go 1.4, fixing vet and ssh issues, and most importantly, disabling hg implementation tests because they are not functional at this time (see issue #104).