v1.0.4 Has a Broken Path

[jmuldoon]

edit: updated how to recreate

go get -u github.com/golangci/golangci-lint/cmd/golangci-lint will fail when hitting this dep

go get: github.com/spf13/pflag@v1.0.3 updating to
        github.com/spf13/pflag@v1.0.4: parsing go.mod:
        module declares its path as: github.com/spf13/pflags
                but was required as: github.com/spf13/pflag

[cfromknecht]

we are seeing the same issue here https://travis-ci.org/lightningnetwork/lnd/jobs/586171113

this is coming from installing https://github.com/ory/go-acc

[cfromknecht]

It seems the issue is being caused because v1.0.4 is still requiring v1.0.3

require github.com/spf13/pflag v1.0.3

[mback2k]

Go 1.13 go get -u also reports this:

verifying github.com/spf13/pflag@v1.0.4/go.mod: checksum mismatch
	downloaded: h1:5F7vF+0t+QPgqofPFTZZG2xnxtA/FGYmPu6WbdsXIvo=
	sum.golang.org: h1:SpGzs/otoxJg1kCwgj9MIIWODxcr65fui/Dn/ZF6H9E=

SECURITY ERROR
This download does NOT match the one reported by the checksum server.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

For more information, see 'go help module-auth'.

[aelse]

I encountered the same. Please tag v1.0.5 after merge as 1.0.4 is poisoned. Thank you dear maintainers 😄

[therealmitchconnors]

#219 merged. Creating rc release now, to ensure we have this fixed.

[therealmitchconnors]

v1.0.5-rc1 is out https://github.com/spf13/pflag/releases/tag/v1.0.5-rc1

Please report here if this resolves your issue.

[cfromknecht]

thank you @therealmitchconnors! 🎉

[therealmitchconnors]

@cfromknecht does that mean it works for you? It seems to work for me, but I want to be sure before I create the release...

[cfromknecht]

@therealmitchconnors yes v1.0.5-rc1 is working for me, thanks again!

[therealmitchconnors]

ok, based on the feedback, I have shipped v1.0.5. Please re-run go get -u to resolve this message.