Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handle data: and about: protocols better #13490

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kran6a
Copy link

@kran6a kran6a commented Feb 21, 2025

Related: #13231, #13226

Always consider about: and data: protocols internal urls.
Fix the invalid base error by setting base_expression to new URL('#', location) when using the about: or data: protocol.

Sorry for not adding tests. I don't have experience writing tests on browser environments.
I am currently using this PR locally to build widgets that are embedded on a webapp via an iframe with srcdoc. Widgets load and navigation works, but they are so simple I can't ensure there are no bugs even on common use cases.

Note that when using srcdoc you must use absolute URLs or otherwise the iframe will take the host's URL as the base. This is not svelte-kit-specific behavior.

Feel free to try the PR and/or suggest changes and I will add them to the PR when I have some free time.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Feb 21, 2025

🦋 Changeset detected

Latest commit: 864404d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@kran6a kran6a changed the title Main Fix: handle data: and about: protocols better Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant