Fix: handle data:
and about:
protocols better
#13490
Draft
+13
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #13231, #13226
Always consider
about:
anddata:
protocols internal urls.Fix the invalid base error by setting
base_expression
tonew URL('#', location)
when using theabout:
ordata:
protocol.Sorry for not adding tests. I don't have experience writing tests on browser environments.
I am currently using this PR locally to build widgets that are embedded on a webapp via an iframe with
srcdoc
. Widgets load and navigation works, but they are so simple I can't ensure there are no bugs even on common use cases.Note that when using srcdoc you must use absolute URLs or otherwise the iframe will take the host's URL as the base. This is not svelte-kit-specific behavior.
Feel free to try the PR and/or suggest changes and I will add them to the PR when I have some free time.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits