Custom ifinfmsg plugin stopped working with version 0.6

[MJDickensheets]

We have been using a custom plugin module and adding it to the ifinfmsg handler via the following procedure:

from pyroute2.netlink.rtnl import ifinfmsg
ifinfmsg.ifinfbase.ifinfo.data_map.update(
    ifinfmsg.load_plugins_by_path(_plugins)
)

An interface with our custom type can then be added:

ipr = IPRoute()
ipr.link("add", kind="custom-kind", msgfield1="data")

As of version 0.6, the link("add") results in pr2modules.netlink.exceptions.NetlinkError: (22, 'Invalid argument'). Some investigation revealed that the ifinfmsg instance visible to the IPRoute object did not have its ifinfo.data_map updated as we would have expected.

As a side note, it would also be nice to have a proper API with which to load plugins, particularly dynamically and not just at import time.

[svinota]

Got it, working on the issue.

[svinota]

@MJDickensheets pls review the commit: 7dd1d55

it is also possible to override existing kinds like to make your own bridge, bond etc. implementation

[MJDickensheets]

Looks like there may be a left-over print statement, but otherwise I think this will do very nicely for our purposes. Thank you for the quick work!

[svinota]

Please reopen the ticket if there will be issues with the functionality, I'm to fix it asap.

[MJDickensheets]

I have tested the fix/feature from my end, everything appears to be working as expected. Would it be possible to schedule a tagged release in the near term?

[svinota]

0.6.8 is to be tagged on Saturday.