Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ss2 - catch further user context instabilities #1088

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

cherusk
Copy link
Contributor

@cherusk cherusk commented Apr 19, 2023

Move execpton handling further up and catch further perceived exception cases that disturb the user context during forming.

@cherusk cherusk force-pushed the ss2_further_stabilization branch from 884593f to a9f3156 Compare April 19, 2023 11:36
Broaden exception handling and catch further perceived exception
cases that disturb the user context during forming.
@cherusk cherusk force-pushed the ss2_further_stabilization branch from a9f3156 to a537065 Compare April 19, 2023 11:36
@cherusk
Copy link
Contributor Author

cherusk commented Apr 19, 2023

I cannot comprehend the linter issue. I've already reformatted everything with black linter. 🤷

@cherusk cherusk force-pushed the ss2_further_stabilization branch from 8213486 to efb01df Compare April 22, 2023 18:44
@cherusk
Copy link
Contributor Author

cherusk commented Apr 22, 2023

Ok, reran black with the parameters from the pre-commit config and it seems to pass. 🕺

@svinota
Copy link
Owner

svinota commented Apr 24, 2023

@cherusk Matthias, will you have also ideas on the CI for the tool — pls ping me

And thanks for the PR

@svinota svinota merged commit 31e5601 into svinota:master Apr 24, 2023
@cherusk cherusk deleted the ss2_further_stabilization branch April 25, 2023 18:44
@cherusk
Copy link
Contributor Author

cherusk commented Apr 30, 2023

@svinota sorry to ask again, but could you do another minor release?

@svinota
Copy link
Owner

svinota commented May 3, 2023

Yep, will be done asap

@svinota
Copy link
Owner

svinota commented May 5, 2023

@cherusk done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants