ethtool: statistics support #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stringset length varies by driver and set_id. Hack: The ctypes library does not allow us to assign redefined/resized Gstring structures to the same IfReq because it (rightly) considers a new structure definition incompatible with the original one. If we were to comply with strict type checking we would have to redefine IfReq every time, but that creates new sort of mess. Instead of redefining IfReq we define gstrings structure member as void* pointer and that allows us to reassign resized structure without redefining the whole IfReq every time. The same applies to gstats member.
get_statistics() is not exposed outside of Ioctl submodule because the netlink provides different set of statistics. See ethtool commit f8d2bc2ccd8bb24f42ce5023227f21a6433c782f. Stat names are cached within IoctlEthtool object as they should not ever change, and it serves as optimization for high-frequency stats gathering.
Return stats as list of (key, counter) tuples.
Some drivers, e.g. vmx3, use non-unique key (GSTRING) names
and create some sort of nested structures based on
key name and/or counter value and/or whitespace indentation.
Abbreviated example from vmx3 driver:
[('Tx Queue#', 0),
(' TSO pkts tx', 3637),
(' TSO bytes tx', 14809448),
('Tx Queue#', 1),
(' TSO pkts tx', 46608),
(' TSO bytes tx', 182510287)]
This is driver-dependent and thus up to caller to decide how return
value should be interpreted.
|
@svinota Hello! I don't want to be inpatient, but what do you think about this PR? :-) |
|
Sorry for delay, I was having some issues. And thanks for your patience |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.