generic: add support for dumping policy #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add basic support for dumping the policy data that the kernel can report via CTRL_CMD_GETPOLICY. The current implementation for parsing the mappings is a bit awkward since it relies on a list comprehension to fill in the nla_map used. This is done because the kernel presents some of the sections with nested NLA where the attribute number is actually an index or a command opcode, rather than using an extra attribute. Ideally, the nla or nlmsg classes would be expanded to support this kind of nested substructure. Eventually we probably want to extract the policy data into more useful structures. In particular, converting the command opcodes and attribute ids into human readable names would be ideal. Add a very basic example which simply dumps and prints the policy data for the nlctrl netlink family. Signed-off-by: Jacob Keller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic support for dumping the policy data that the kernel can report
via CTRL_CMD_GETPOLICY.
The current implementation for parsing the mappings is a bit awkward since
it relies on a list comprehension to fill in the nla_map used.
This is done because the kernel presents some of the sections with nested
NLA where the attribute number is actually an index or a command opcode,
rather than using an extra attribute. Ideally, the nla or nlmsg classes
would be expanded to support this kind of nested substructure.
Eventually we probably want to extract the policy data into more useful
structures. In particular, converting the command opcodes and attribute ids
into human readable names would be ideal.
Add a very basic example which simply dumps and prints the policy data for
the nlctrl netlink family.
Signed-off-by: Jacob Keller [email protected]