chore(deps): upgrade Go to v1.23.0 and bump wapc-go #149
Conversation
Upgraded Go for performance because it's always good to stay current. Also bumped wapc-go to v0.7.1, because who doesn't like a little version inflation?
WalkthroughThe pull request focuses on updating the Go module configuration in the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Raised the wattage on wazero for a brighter future. Farewell to wasmtime—your time has ticked away.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (2)
go.mod (2)
96-96: LGTM: wazero version updateThe update of the indirect dependency
github.com/tetratelabs/wazeroto v1.8.2 is valid and aligns with the wapc-go upgrade.
Line range hint
26-96: Verify dependency compatibilityLet's ensure all WebAssembly-related dependencies are compatible and check for any breaking changes.
✅ Verification successful
Dependencies are compatible and up-to-date ✅
The WebAssembly-related dependencies are compatible, and the recent updates contain only bug fixes and improvements. Module verification completed successfully with no issues detected.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for compatibility issues between WebAssembly-related dependencies # Get go.mod contents from relevant versions echo "Checking wapc-go v0.7.1 dependencies..." curl -s "https://raw.githubusercontent.com/wapc/wapc-go/v0.7.1/go.mod" echo -e "\nChecking wazero v1.8.2 release notes for breaking changes..." curl -s "https://api.github.com/repos/tetratelabs/wazero/releases/tags/v1.8.2" | jq -r '.body' echo -e "\nVerifying module compatibility..." go mod verifyLength of output: 799
Updating TinyGo is like upgrading from a tricycle to a bicycle—wobbly at first, but way faster!
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
testdata/sdkv1/logger/Makefile (1)
5-5: Consider avoiding root user in Docker build.While the TinyGo version update is good, running the container as root (
-u root) might pose unnecessary security risks. Consider if root privileges are actually required for the build process.- docker run --rm -v `pwd`/:/build -w /build -u root tinygo/tinygo:0.34.0 tinygo build -o /build/tarmac.wasm -target wasi /build/main.go + docker run --rm -v `pwd`/:/build -w /build tinygo/tinygo:0.34.0 tinygo build -o /build/tarmac.wasm -target wasi /build/main.gotestdata/base/kv/Makefile (1)
5-5: Consider consolidating common build commands.The build command is identical across multiple Makefiles. Consider creating a shared Makefile or using Make includes to reduce duplication and maintain consistency.
Example approach:
- Create a shared Makefile (e.g.,
build/common.mk):TINYGO_VERSION := 0.34.0 define build_wasm docker run --rm -v `pwd`/:/build -w /build tinygo/tinygo:$(TINYGO_VERSION) tinygo build -o /build/tarmac.wasm -target wasi /build/main.go endef
- Include in each Makefile:
include ../../build/common.mk build: $(call build_wasm)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (12)
example/echo/go/Makefile(1 hunks)example/tac/go/Makefile(1 hunks)testdata/base/default/Makefile(1 hunks)testdata/base/fail/Makefile(1 hunks)testdata/base/function/Makefile(1 hunks)testdata/base/kv/Makefile(1 hunks)testdata/base/logger/Makefile(1 hunks)testdata/base/sql/Makefile(1 hunks)testdata/base/successafter5/Makefile(1 hunks)testdata/sdkv1/kv/Makefile(1 hunks)testdata/sdkv1/logger/Makefile(1 hunks)testdata/sdkv1/sql/Makefile(1 hunks)
✅ Files skipped from review due to trivial changes (9)
- testdata/sdkv1/sql/Makefile
- testdata/sdkv1/kv/Makefile
- testdata/base/fail/Makefile
- example/tac/go/Makefile
- testdata/base/function/Makefile
- testdata/base/successafter5/Makefile
- testdata/base/sql/Makefile
- testdata/base/default/Makefile
- testdata/base/logger/Makefile
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: tests
- GitHub Check: redis
- GitHub Check: mysql
- GitHub Check: postgres
- GitHub Check: in-memory
- GitHub Check: boltdb
- GitHub Check: golangci
- GitHub Check: cassandra
- GitHub Check: build
🔇 Additional comments (1)
example/echo/go/Makefile (1)
5-5: Verify TinyGo version compatibility.The PR objectives mention compatibility with TinyGo 0.35.0, but the Makefile is being updated to use version 0.34.0. Please confirm if this is intentional or if we should be using version 0.35.0 instead.
✅ Verification successful
TinyGo version 0.34.0 is correctly specified
The version choice is consistent with all other Makefiles in the project, maintaining uniformity across test data and examples. While the PR aims for 0.35.0 compatibility, using 0.34.0 for builds appears to be the project standard.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check TinyGo version compatibility with the project # Check if there are any version constraints or compatibility notes in project docs fd -t f -e md | xargs rg -i "tinygo.*version|compatibility.*tinygo" # Check if there are any version-specific configurations in other files rg -i "tinygo.*0.3[45]"Length of output: 2064
Upgraded Go for performance because it's always good to stay current. Also bumped wapc-go to v0.7.1, to address issues with TinyGo 0.35.0
Summary by CodeRabbit