De-duplicate starfish mock client

[samyfodil]

starfish is a mock client for patrick. The problem is that it is defined 3 times. See:

tau/services/monkey/patrick_struct_test.go

Line 13 in e8236cd

type starfish struct {

tau/services/monkey/tests/patrick_struct_test.go

Line 13 in e8236cd

type starfish struct {

tau/clients/p2p/monkey/tests/patrick_struct_test.go

Line 13 in e8236cd

type starfish struct {

We need to consolidate in one place under clients/p2p/patrick/mock

[vasnt]

Random queries:

• How did you find/know these duplicates?
• Do you think there are other such duplicates?

[samyfodil]

@vasnt I did a search after noticing we have two. because an interface is used for patrick client, we can replace it with starfish to mock it. it should be easy to move one of the files (maybe merge any method that's extra in others), then export starfish (turn it to Starfish - notice the upper case "S", that's how you do it in go). after that you just need to use Starfish in all the tests using starfish, then delete all the files for starfish that are now unused.

If you're going to work on it:

• I recommend having go install on your laptop
• Install the go ext for vscode or your favorite IDE
• I'll help with running tests if you encounter an issue

[vasnt]

So are you proposing any edit/changes in this issue#174 description? If yes, please do.

@vasnt I did a search after noticing we have two. because an interface is used for patrick client, we can replace it with starfish to mock it. it should be easy to move one of the files (maybe merge any method that's extra in others), then export starfish (turn it to Starfish - notice the upper case "S", that's how you do it in go). after that you just need to use Starfish in all the tests using starfish, then delete all the files for starfish that are now unused.

[samyfodil]

@vasnt just adding context and describing steps.

[samyfodil]

fixed #222