refactor: retry logic for deployment key #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samyfodil
requested changes
Jul 16, 2024
services/monkey/helpers.go
Outdated
| @@ -39,3 +43,79 @@ func (m *Monkey) storeLogs(r io.ReadSeeker) (string, error) { | |||
|
|
|||
| return cid, nil | |||
| } | |||
|
|
|||
| // Retry function with a custom condition | |||
| func Retry(maxRetries int, waitBeforeRetry time.Duration, operation interface{}, condition interface{}, args ...interface{}) ([]interface{}, error) { | |||
There was a problem hiding this comment.
tests are passing. however, i'm no sure using interface{} (should be any btw) is a good choice here.
make a retry just for our use case since it's used only once.
There was a problem hiding this comment.
Thanks for your comment. I have reverted and moved the retry logic to helpers.
I just needed one advise on how to get the global variable for maxRetries and waitBeforeRetry?
samyfodil
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #152
Sometimes, a build might be triggered before the repository is registered, which mean a deployment key was added. For these reason we have a retry logic here https://github.com/taubyte/tau/services/monkey/job.go#L88. Frankly, this code does not look good.
I suggest moving the check for deployment key to https://github.com/taubyte/tau/services/monkey/job.go#L41, and use a helper function that will retry for a number of times till we get repo with a deployment key.
Add a reusable Retry helper function.