Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update page.mdx #6270

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Update page.mdx #6270

merged 1 commit into from
Feb 17, 2025

Conversation

warengonzaga
Copy link
Member

@warengonzaga warengonzaga commented Feb 17, 2025

Update "extension" to "extensions"


PR-Codex overview

This PR updates the import path for the balanceOf function from thirdweb/extension/erc1155 to thirdweb/extensions/erc1155, ensuring the correct module is referenced for checking the balance of a wallet in the application.

Detailed summary

  • Changed import path for balanceOf from thirdweb/extension/erc1155 to thirdweb/extensions/erc1155.
  • Added a newline at the end of the file.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 3:03am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) Feb 17, 2025 3:03am
thirdweb_playground ⬜️ Skipped (Inspect) Feb 17, 2025 3:03am
thirdweb-www ⬜️ Skipped (Inspect) Feb 17, 2025 3:03am
wallet-ui ⬜️ Skipped (Inspect) Feb 17, 2025 3:03am

@vercel vercel bot temporarily deployed to Preview – wallet-ui February 17, 2025 02:15 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 17, 2025 02:15 Inactive
@warengonzaga warengonzaga requested review from a team as code owners February 17, 2025 02:15
Copy link

changeset-bot bot commented Feb 17, 2025

⚠️ No Changeset found

Latest commit: e386ac9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 17, 2025 02:15 Inactive
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Feb 17, 2025
Copy link

graphite-app bot commented Feb 17, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.87%. Comparing base (0574eac) to head (e386ac9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6270   +/-   ##
=======================================
  Coverage   56.87%   56.87%           
=======================================
  Files        1166     1166           
  Lines       64629    64629           
  Branches     5242     5242           
=======================================
  Hits        36755    36755           
  Misses      27146    27146           
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 0574eac
packages 55.08% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Feb 17, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 465 ms (+41.05% 🔺) 1.4 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 944 ms (+25.14% 🔺) 3.4 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 71 ms (+404.54% 🔺) 182 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 50 ms (+873.4% 🔺) 60 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 95 ms (+43.84% 🔺) 481 ms

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Feb 17, 2025
Copy link
Member

gregfromstl commented Feb 17, 2025

Merge activity

  • Feb 16, 10:00 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 16, 10:00 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 16, 10:04 PM EST: A user merged this pull request with the Graphite merge queue.

Update "extension" to "extensions"

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the import path for the `balanceOf` function from the `thirdweb/extension/erc1155` to `thirdweb/extensions/erc1155`, ensuring that the correct module is referenced for checking wallet balances.

### Detailed summary
- Changed the import statement for `balanceOf` from `thirdweb/extension/erc1155` to `thirdweb/extensions/erc1155`.
- Added a newline at the end of the file.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the warengonzaga-patch-1 branch from 350a4c5 to e386ac9 Compare February 17, 2025 03:01
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 17, 2025 03:01 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 17, 2025 03:01 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 17, 2025 03:01 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 17, 2025 03:01 Inactive
@graphite-app graphite-app bot merged commit e386ac9 into main Feb 17, 2025
31 of 32 checks passed
@graphite-app graphite-app bot deleted the warengonzaga-patch-1 branch February 17, 2025 03:04
@vercel vercel bot temporarily deployed to Production – login February 17, 2025 03:04 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 17, 2025 03:04 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui February 17, 2025 03:04 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www February 17, 2025 03:04 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants