Wrong URL for attachments using relative_url_root

[infertux]

If I set a relative root URL for my Rails app using config.action_controller.relative_url_root = '/sub', links to attachments don't include /sub, i.e. :

• got: https://example.com/system/documents/assets/...
• expected: https://example.com/sub/system/documents/assets/...

Here's a quick fix but it breaks a bunch of tests. I didn't go through the code thoroughly, this should probably be fixed in a better way.

diff --git lib/paperclip/attachment.rb lib/paperclip/attachment.rb
index 5a92761..ceabe68 100644
--- lib/paperclip/attachment.rb
+++ lib/paperclip/attachment.rb
@@ -23,7 +23,7 @@ module Paperclip
-        :url                   => "/system/:class/:attachment/:id_partition/:style/:filename",
+        :url                   => ":rails_relative_url_root/system/:class/:attachment/:id_partition/:style/:filename",
diff --git lib/paperclip/interpolations.rb lib/paperclip/interpolations.rb
index 1f867b3..81600a0 100644
--- lib/paperclip/interpolations.rb
+++ lib/paperclip/interpolations.rb
@@ -75,6 +75,11 @@ module Paperclip
+    # Returns the relative_url_root constant as a string.
+    def rails_relative_url_root attachment, style_name
+      Rails.application.config.action_controller.relative_url_root.to_s
+    end
+

(to_s to make sure we get an empty string if the constant is not defined)

Related: #25

[jyurek]

Thank for this. We don't get this problem much (I guess people don't use relative roots much), but I can imagine it's annoying. I'm going to close it for now, but it would be great if you could submit it as a pull request with tests.

[kabturek]

the issue exists so why close it ? if someone submits a pull request it can be referenced here and closed when the issue will be fixed.

[jgrevich]

@kabturek

I often run apps using a relative_url_root and believe this to be an issue as well. +1 on reopening the issue until we have a pull request to fix it.

[huoxito]

Agreed that it sucks Paperclip doesn't take relative_url_root into account but as @infertux noted it's pretty easy to make it work:

Paperclip.interpolates :rails_relative_url_root  do |attachment, style|
  Rails.application.config.action_controller.relative_url_root.to_s
end

We just need to add that interpolation ourselves to the :url option

[u007]

try this:
hope someone can change this to check for existence of relative url and append suffix as shown below:

Paperclip::Attachment.class_eval do 

  def url(style_name = default_style, options = {})
    if options == true || options == false # Backwards compatibility.
      res = @url_generator.for(style_name, default_options.merge(:timestamp => options))
    else
      res = @url_generator.for(style_name, default_options.merge(options))
    end
    # replace adding uri before res, minus final /
    Rails.application.config.site_relative_url[0..-2]+res
  end

end