Support a custom includes path

[codekoala]

This adds support for a custom includes path. This helps when you do not have permission to modify /usr/local/include, for example.

It relies on the standard -I flag, so something like make -I /tmp/custom/path and make -I/var/lib/whatever work.

[codekoala]

@tj any thoughts on this? I have a project waiting on this feature for its build pipeline.

[tj]

hmm not something I need personally. I'm not a huge fan of replacing pkg-level globals from an API, but I think otherwise looks decent to me!

I kinda feel like using -I ruins any niceness that is provided by mmake but I'm not sure what your use-case is.

[codekoala]

Thank you for the feedback!

I'm trying to use mmake in a build pipeline that does not provide write access to the build system's /usr/local/include directory. Using the -I ./include or whatever allows me to still pull in all of the dependencies using mmake's magic, but instead of writing those includes to /usr/local/include they're written to a location the build job has write access to.

[tj]

is this line necessary if it's defaulted above?

[codekoala]

That's a good question. I know I had a reason for doing it this way, but that reason escapes me at this moment. I'll have to take a closer look at the whole diff when I get back to a computer.

[codekoala]

I think I added this line so the test results would be consistent. Without it, the expected outcome for later tests would not match. This being the case, I'll just reset IncludePath in the test instead.

[tj]

SGTM! just one question about the one line but otherwise I'll merge!

[codekoala]

@tj this should be good to go now. Thanks!

[codekoala]

@tj any other objections?

[zph]

Per #34, I'm merging approved features to tidy up PR/issues.

Looks good @codekoala, thank you for the feature.

I'm considering submitting a PR later that makes this functionality available via an env variable MMAKE_INCLUDE. I know for my own environment I like to isolate where things are installed.... so default would stay the same but if MMAKE_INCLUDE is set then I could setup ~/.config/mmake/include as the storage location.

(Looks like my conflict resolution in GH interface failed on CI. Will pull down and re-do).

[zph]

Squashing and merging this and pushing a follow on commit to fix test reporting that changed. Thanks @codekoala!

[codekoala]

Thank you for merging!!!

…

On Sat, Sep 21, 2019, 16:23 Zander Hill ***@***.***> wrote: Squashing and merging this and pushing a follow on commit to fix test reporting that changed. Thanks @codekoala <https://github.com/codekoala>! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#25?email_source=notifications&email_token=AAAL4OQ4QAKJC6OAW2ZK4LTQKZ7EFA5CNFSM4ED2BXX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7IZAZY#issuecomment-533827687>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAL4OS5DWKODXT6HEOOYOTQKZ7EFANCNFSM4ED2BXXQ> .

[zph]

👍 💃