Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vagrant, vagrant-plugin: add French translation #15735

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

aminelch
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new translation PRs translating a page(s) from English to other languages. label Feb 14, 2025
@spageektti spageektti changed the title Vagrant: add French translation vagrant, vagrant-plugin: add French translation Feb 15, 2025
@aminelch aminelch requested a review from noraj February 15, 2025 22:44
@aminelch
Copy link
Contributor Author

@noraj @nicokosi @Nico385412 can you check my changes

@noraj
Copy link
Collaborator

noraj commented Feb 17, 2025

Also, while greffons (technically the best translation) and plugiciels (maybe only used in Quebec) are 100% correct, they may be less commonly used than modules or extensions. So you can choose to keep it or to adopt or more spread synonym, it's totally up to you.

Co-authored-by: Alexandre ZANNI <[email protected]>
aminelch and others added 4 commits February 21, 2025 14:49
@aminelch aminelch closed this Feb 21, 2025
@noraj noraj reopened this Feb 21, 2025
Copy link
Collaborator

@noraj noraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this check:

The page pages.fr/common/vagrant-plugin.md is outdated, based on the command contents itself, compared to the English page.

It's a false positive, it's actually the english page that contains an error: #15767.

Copy link
Collaborator

@noraj noraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thank you for your work @aminelch.

@tldr-bot

This comment was marked as resolved.

@aminelch
Copy link
Contributor Author

LGTM now. Thank you for your work @aminelch.

welcome

@aminelch aminelch requested review from nicokosi and noraj February 21, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new translation PRs translating a page(s) from English to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants