Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print: add disambiguation page #15746

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

print: add disambiguation page #15746

wants to merge 3 commits into from
+32 −17

Conversation

acuteenvy
Copy link
Member

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.

I've also renamed the Windows page for print, because if we leave it as print.md, clients on Windows will show that page instead of the disambiguation from common.

This is a solution chosen in #8786 and implemented for just in #10783. It would be great to document this in the style guide.

The Zsh print page was added in #15597.
Closes #15605.

@acuteenvy
print: rename pages
8da54dd 
common/print.md  => common/print.zsh.md
linux/print.md   => linux/print.runmailcap.md
windows/print.md => windows/print.win.md
@acuteenvy
print: add disambiguation page
734f7d9
@acuteenvy acuteenvy added the decision A (possibly breaking) decision regarding tldr-pages content, structure, infrastructure, etc. label Feb 18, 2025
@acuteenvy acuteenvy requested a review from cyqsimon as a code owner February 18, 2025 00:41
@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. page edit Changes to an existing page(s). labels Feb 18, 2025
gutjuri
gutjuri approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tldr-bot

This comment was marked as resolved.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@gutjuri gutjuri gutjuri approved these changes

@cyqsimon cyqsimon Awaiting requested review from cyqsimon cyqsimon is a code owner

Assignees
No one assigned
Labels
decision A (possibly breaking) decision regarding tldr-pages content, structure, infrastructure, etc. new command Issues requesting creation of a new page or PRs adding a new page for a command. page edit Changes to an existing page(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

page conflict: print
4 participants
@acuteenvy @tldr-bot @sebastiaanspeck @gutjuri