-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow: add coverage check configuration #114
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
===================================================
- Coverage 85.60258% 85.52811% -0.07448%
===================================================
Files 188 188
Lines 16114 16114
===================================================
- Hits 13794 13782 -12
- Misses 1755 1777 +22
+ Partials 565 555 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
.github/codecov.yaml
Outdated
@@ -0,0 +1,4 @@ | |||
comment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
默认设置不允许覆盖率下降。可以增加下覆盖率要求的配置,例如允许下降幅度1%
coverage:
status:
project:
default:
threshold: 1%
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to modify the Global yml file under the trpc-group organization on the codecov platform, but I found that some settings have taken effect while others haven't.
coverage:
precision: 5 // have taken effect
range: // haven't taken effect
- 90.0
- 100.0
status:
project:
default:
branches:
- ^main$
target: 100.0
threshold: 0.0
Codecov provides a user interface to adjust a "Global YAML", which overrides the default settings in Codecov. It is applied to all repositories in the Global. Only Global administrators can adjust the Global YAML in Codecov. All changes are stored in history.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The configuration actually took effect, there might have been a delay before, which resulted in no observations being made.
5d4ae8c
to
bb701f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.