Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add comments informing that global variable JSONAPI should not be modified (#157) #160

Merged

Conversation

Andrew-M-C
Copy link
Contributor

docs: add comments informing that global variable JSONAPI should not be modified (#157)

Discussions took place in #157

Copy link
Contributor

@WineChord WineChord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (65a60b1) 85.52917% compared to head (c15d95a) 85.64697%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main        #160         +/-   ##
===================================================
+ Coverage   85.52917%   85.64697%   +0.11780%     
===================================================
  Files            189         189                 
  Lines          16129       16129                 
===================================================
+ Hits           13795       13814         +19     
+ Misses          1774        1753         -21     
- Partials         560         562          +2     
Flag Coverage Δ
unittests 85.64697% <ø> (+0.11780%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andrew-M-C Andrew-M-C force-pushed the feature/json_deprecated_comment branch from ae69f71 to c15d95a Compare January 23, 2024 01:33
@Andrew-M-C
Copy link
Contributor Author

Changed the position of Deprecated: for lint in CI

@sandyskies sandyskies merged commit 5dad29f into trpc-group:main Jan 25, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants