Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Bindings::resolve_and_remove method #501

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Remove Bindings::resolve_and_remove method #501

merged 1 commit into from
Nov 15, 2023

Conversation

vsbogd
Copy link
Collaborator

@vsbogd vsbogd commented Nov 15, 2023 •
edited
Loading

Remove resolve_and_remove because it makes logic of Bindings more complex and doesn't add anything valuable. It can be replaced by applying Bindings to the variable.

luketpeterson
luketpeterson approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@luketpeterson luketpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this clean-up

@vsbogd vsbogd merged commit 6f13bb0 into trueagi-io:main Nov 15, 2023
@vsbogd
Copy link
Collaborator Author

vsbogd commented Nov 15, 2023

Thanks Luke!

@vsbogd vsbogd deleted the remove-resolve-and-remove branch November 15, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luketpeterson luketpeterson luketpeterson approved these changes

@Necr0x0Der Necr0x0Der Awaiting requested review from Necr0x0Der

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsbogd @luketpeterson