Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for parsing escape sequences in s-expression parser #628

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

luketpeterson
Copy link
Contributor

Intended to address #619

ngeiswei
ngeiswei previously approved these changes Mar 19, 2024
Copy link
Contributor

@ngeiswei ngeiswei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me, thanks @luketpeterson !

vsbogd
vsbogd previously approved these changes Mar 19, 2024
Copy link
Collaborator

@vsbogd vsbogd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Luke, I am happy to approve this but I suggest removing the one-digit logic.

Co-authored-by: Vitaly Bogdanov <[email protected]>
@luketpeterson luketpeterson dismissed stale reviews from vsbogd and ngeiswei via b2c3706 March 19, 2024 12:36
@luketpeterson luketpeterson requested a review from vsbogd March 19, 2024 14:49
@vsbogd vsbogd merged commit d7d421c into trueagi-io:main Mar 19, 2024
2 checks passed
vsbogd added a commit to vsbogd/hyperon-experimental that referenced this pull request Mar 20, 2024
Adding support for parsing escape sequences in s-expression parser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants