include op to return results from evaluated sub-script
#684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom before module isolation
vsbogd
reviewed
May 6, 2024
| // `import!` before before module isolation. However that means the results prior to | ||
| // the last are dropped. I don't know how to fix this or if it's even wrong, but it's | ||
| // different from the way "eval-type" APIs work when called from host code, e.g. Rust | ||
| Ok(eval_result.into_iter().last().unwrap_or_else(|| vec![])) |
There was a problem hiding this comment.
Well, yeah, as only last result is returned and other are dropped I am not sure if this really required change. On the other hand I don't object so we can merge it. @TeamSPoon does this change help?
vsbogd
approved these changes
May 6, 2024
|
@luketpeterson , please change |
|
Ah. Oops. Thanks for catching that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change requested by @TeamSPoon to match behavior of the old
importop. With this change, theincludeop will return the last result from evaluating the sub-script.