Minimal MeTTa interpreter written mostly in Rust #728
Conversation
It is needed because grounded atoms doesn't take into account bindings contents.
old_interpreter feature can be used to switch back to the previous Rust interpreter. Add (interpret atom type space) to the old interpreter for compatibility. Remove previous minimal MeTTa interpreter. Fix unit tests which depends on a bare interpreter.
Add Python atom to designate MeTTa interpreter call and use it in unit tests.
|
This speedup is huge! 50x in some of the interpreter benchmarks. I'll work on the line-by-line review, but I am very happy with the performance boost. UpdateNot only is the new interpreter much faster, but the scaling properties are better for recursion. The old interpreter(s) paid quadratic cost, this one is almost linear. |
lib/src/metta/mod.rs
Outdated
| @@ -1,9 +1,12 @@ | |||
| //! Contains MeTTa specific types, constants and functions. | |||
|
|
|||
| pub mod text; | |||
| #[cfg(feature = "old_interpreter")] | |||
| pub mod interpreter; | |||
There was a problem hiding this comment.
Should the interpreter files be renamed? Now that interpreter_minimal is default...
Honestly I think it doesn't matter because there is probably not much reason to keep the old interpreter much longer. Speed was the biggest reason, but the new interpreter is much faster than the old one.
There was a problem hiding this comment.
Thanks Luke, it is a nice point. I renamed interpreter.rs to old_interpreter.rs (see 2bd7502) but there is also part of stdlib.rs related to the old interpreter. I think it will be simpler to refactor this in a one step when old interpreter is being removed. Anyway old_interpreter.rs sounds more clear and aligned with old_interpreter feature.
I am still not sure if we need to rename interpreter_minimal.rs to the interpreter.rs. Minimal MeTTa is has evaluation order which is different from MeTTa evaluation order. I think in the future we could allow more flexible evaluation control in MeTTa and then minimal MeTTa is not needed. On the other hand main structure of the interpreter (except the set of instructions) probably will be the same. By this reason I would prefer keep it as interpreter_minimal.rs for a while.
lib/src/metta/interpreter_minimal.rs
Outdated
There was a problem hiding this comment.
Are the docs in docs/minimal-metta.md still accurate?
I tried to render a diagram from the code using GPT. Results at the link below. Not great but perhaps a starting point.
There was a problem hiding this comment.
Are the docs in docs/minimal-metta.md still accurate?
Yes, previous implementation was not changed. But you are right it is worth mentioning Rust implementation of the MeTTa interpreter. I added a note about it in 8cae12e. Also some variable scope questions are more clear now and I think I will add documentation for it in a separate PR.
I tried to render a diagram from the code using GPT.
Interesting experiment. Not sure what is simpler though: to draw new diagram or to finish this one :-)
"old_interpreter" feature is added to switch back to the Rust interpreter if needed.
New
mettaoperation is added into minimal interpreter in order to call Rust MeTTa interpreter implementation. Rust interpreter is fixed to consumemettaoperation passed. Interpreter unit tests are fixed to be compatible with minimal MeTTa interpreter.Legacy
common/arithmetics.rsmodules is removed.Old MeTTa interpreter written in MeTTa is removed.