Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs cleanup #404

Merged
merged 4 commits into from
Mar 4, 2014
Merged

Docs cleanup #404

merged 4 commits into from
Mar 4, 2014
+31 −187

Conversation

connors
Copy link
Collaborator

@connors connors commented Mar 4, 2014

Just a bit of docs cleanup to remove unused CSS.

  1. Got rid of the grid css that we don't need
  2. Refactored the docs headers that used the grid un necessarily.

@connors connors added the docs label Mar 4, 2014
@connors connors added this to the 2.0.1 milestone Mar 4, 2014
mdo
mdo reviewed Mar 4, 2014
View reviewed changes
docs/assets/css/docs.css

.column-group:before,
.column-group:after {
.column-group:before, .column-group:after {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep em on separate lines bb.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's not like that in the sass file. Happens when Grunt compiles it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my bad. We can clean that up later with a Grunt task via CSScomb I think. :shipit:!

@mdo
Copy link
Member

mdo commented Mar 4, 2014

One fix and then :shipit:.

connors added a commit that referenced this pull request Mar 4, 2014
@connors
Merge pull request #404 from twbs/docs-cleanup
d0a0685 
Docs cleanup
@connors connors merged commit d0a0685 into master Mar 4, 2014
@connors connors deleted the docs-cleanup branch March 4, 2014 04:37
@mdo mdo mentioned this pull request Mar 4, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@connors @mdo