Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix handling of umask on macOS #4298

Merged
merged 1 commit into from
Feb 23, 2025
Merged

fix: Fix handling of umask on macOS #4298

merged 1 commit into from
Feb 23, 2025
+0 −0

Conversation

twpayne
Copy link
Owner

@twpayne twpayne commented Feb 23, 2025

Fixes #4214.
Refs #4296.

@twpayne @hugoh @halostatue
fix: Fix handling of umask on macOS
8654a14 
Co-authored-by: Hugo Haas <[email protected]>
Co-authored-by: Austin Ziegler <[email protected]>
halostatue
halostatue approved these changes Feb 23, 2025
View reviewed changes
Copy link
Collaborator

@halostatue halostatue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue in my testing. I would have seen this if I’d been a bit smarter in my grepping:

rg chezmoitest -l | grep -v _test

If I had done instead

rg chezmoitest | grep -v '_test.go'

it would have been visible.

@halostatue halostatue mentioned this pull request Feb 23, 2025
Closed
@twpayne twpayne marked this pull request as ready for review February 23, 2025 22:12
@twpayne twpayne merged commit b8d9670 into master Feb 23, 2025
32 checks passed
@twpayne twpayne deleted the fix-4214 branch February 23, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halostatue halostatue halostatue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

git-repo external and umask don't play nice
2 participants
@twpayne @halostatue