Skip to content

GitHub Actions don't appear to test as intended #1472

Closed
@thorrak

Description

@thorrak

Just a heads up - I don't think that your GitHub Actions are testing PRs as intended. From looking at the action, I noticed the following line:

https://github.com/tzapu/WiFiManager/blob/master/.github/workflows/compile_examples.yaml#L111

...which seems to re-clone the active master from your repo to build against rather than using the "incoming" code from a PR. To test this, I created this commit which deletes all the code, and then submitted this PR on which all the checks succeed.

My expectation is that compile examples should fail given all the code was deleted.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    TaskNon Code Related Task

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions