trivial: WiFiManagerParameter get accessors should work on const #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ances Enhancement: It should be okay to invoke getID() and getValue() in a const instance of the WiFiManagerParameter class. See: flavio-fernandes/persistWifiSetting@135adb1
flavio-fernandes
force-pushed
the
constWiFiManagerParameter
branch
from
5bc8132 to
8935680
Compare
|
Could this break anything ? |
tablatronix
added
Discussion
I don't think so. If anything, it is just making it possible to be used by a constant instance of the class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: It should be okay to invoke getID() and getValue() in a
const instance of the WiFiManagerParameter class.
For usage example, see: flavio-fernandes/persistWifiSetting@135adb1