Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI / DC Update - Library Build, Linting, Examples Json Fix #1264

Merged
merged 10 commits into from
Sep 17, 2021

Conversation

shafr
Copy link
Contributor

@shafr shafr commented Jun 22, 2021

Updated:

Examples compilation in one file. Using ArduinoJson v5 for now.

Added

Library building
Linting on pull request

@shafr shafr changed the title ESP32 & ESP8266 examples test check CI / DC Update - Library Build, Linting, Examples Json Fix Jul 1, 2021
@tablatronix
Copy link
Collaborator

This combines both platforms?

@shafr
Copy link
Contributor Author

shafr commented Jul 1, 2021

it has both esp8266 & esp32 library builds & example builds

@tablatronix
Copy link
Collaborator

Thanks!

@tablatronix tablatronix merged commit 2d2b9f8 into tzapu:master Sep 17, 2021
@tablatronix
Copy link
Collaborator

merged and fixed up
stupid question why are the boards reversed?

esp32:
run: pio ci --board=nodemcuv2

@shafr
Copy link
Contributor Author

shafr commented Sep 17, 2021

yep, thats bug, please reverse

@tablatronix
Copy link
Collaborator

oddly it was working just fine

@tablatronix tablatronix added enhancement Feature Request Task Non Code Related Task labels Sep 17, 2021
@shafr
Copy link
Contributor Author

shafr commented Sep 17, 2021

also you can check my 'canary' repo actions - i have one that calculates FW / disk usage for pull requests

@tablatronix
Copy link
Collaborator

interesting, I will check it out, I need to work on doxygen

@tablatronix
Copy link
Collaborator

looks like we have a mix of yml and yaml, which one is best more standard?
I always use .yaml

@shafr
Copy link
Contributor Author

shafr commented Sep 24, 2021

There's no rule, probably I was not paying attention, I prefer using shortest one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature Request Task Non Code Related Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants