Change Stream to Print #1307
Merged
Change Stream to Print #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update WifiManager to use base class Print instead of Stream. I debug into a custom buffer, and that buffer implements Print, but not Stream.
Update WifiManager to use base class Print instead of Stream. I debug into a custom buffer, and that buffer implements Print, but not Stream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WifiManager does not use any
Streamfunctionality for_debugPort; change the declaration of_debugPortso that it is more easily used by other implementations.Personally, I use a ring buffer that implements Print but not Stream for reading.