Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor strings BREAKING #1474

Merged
merged 8 commits into from
Nov 28, 2022
Merged

Refactor strings BREAKING #1474

merged 8 commits into from
Nov 28, 2022

Conversation

tablatronix
Copy link
Collaborator

This is a possible breaking change if you have modified your strings file.

  • Constants have been moved to wm_consts_en.h
  • strings has been renamed to wm_strings_en.h, with shim left in
  • adds WM_STRINGS_FILE for env override of string asset
  • strings file MUST include a consts file as it contains localized tokens which are still used for web paths and error msgs and tokens

You will have to remove the constants from your strings files and add the new include instead, a simple diff should obviously show the changes
@tablatronix
Copy link
Collaborator Author

Shit, I should not have moved the file in this commit, now you cannot see the diff!

@tablatronix
Copy link
Collaborator Author

@tablatronix tablatronix merged commit 0080e35 into master Nov 28, 2022
@tablatronix tablatronix deleted the refactor_strings branch November 28, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Flagged for docs enhancement Feature Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant