-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Added OTA updater option from esp8266 #587
Conversation
…Windeler but modified in some pieces to fit current library version
@tablatronix |
I doubt it needs to be in core. Unless its very lightweight |
…f lib Debug output corrected at some point
I thought about refactoring menu and routes, so you can easily add menuoptions and routes, with callouts then you can just add this stuff fairly easily without modifying the lib. |
The libs needed seems to be already included per default in esp8266 core. But there are some additional strings needed for the pages. Not sure if this is lightweight enough. If you provide callbacks i could separate the update stuff in another class. But it would need some access to the server object. |
In general, the pull request works on eps8266. But i haven't tested it on an ESP32. Im also not sure, what breaks the example tests. |
This is the error:
Maybe that does not exist for the esp32 or has a different name? |
I can't believe it... https://github.com/espressif/arduino-esp32/tree/master/libraries/Update/src
|
You should install the esp32 Arduino and test compile as there are some class differences.....
|
I would file that as a bug with esp32 thats messed up, and yeah ota for esp32 is fairly different, Although converging the 2 is probably on the roadmap |
I corrected the compile errors with esp32. I haven't tested the ota feature on an ESP32. But on 8266 it works |
Merged into ota branch for testing. I an probably going to pull this out into an example with user code insread of core, but this is working and testable, I added todos to code |
you need to fix your strings menu_ids it is missing the update token |
sorry, i forgot to check this |
I'm not sure what ist open to geht this also in the Development branch. One thing which ist absolutely a must ist a password protection i think. |
There is an ota branch for this, it works |
I know. I'm testing the ota branch currently in my project. |
it has not been tested well and probably needs some minor improvements |
Added OTA update support in config portal page