Fix crasahes in doParamSave() & WiFiManagerParameter::setValue #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a String anyway. Don't use .c_str() when its being assigned to a String anyway
|
Wait on this - I think I'm still getting crashes :-( |
allocation and not passed length. Changed to use passed length or length of default value if > passed length.
liebman
changed the title
liebman
changed the title
|
Ok so |
|
Sorry about that, I was still testing this to catch some edge cases. I Should have used a branch. |
|
I clicked merge last night I guess It didnt go through oops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had crashes in
doParamSave().Changed to use
server.hasParam()instead of checkingserver.arg()for NULL, it returns aStringnot a pointer.Don't use
.c_str()when its being assigned to aString. I think using.c_str()onStringthat are transient is probably not safe.