Implements #717: Added getParameters and getParametersCount methods. #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for iterating over WiFiManager parameter list
fllaca
force-pushed
the
get_parameters_method
branch
from
307e89f to
b4cc27c
Compare
fllaca
force-pushed
the
get_parameters_method
branch
from
800be56 to
1c191c1
Compare
|
Hi @tablatronix ! Also made some fixes in the tests so they are passing now. |
|
Thanks! |
|
Hi! Any update on this? Do I need to meet any missing requirement to get this PR reviewed/merged? |
|
Yeah I have not had time to look at it yet, if anyone else can sign off. Maybe make a new issue so I can flag it |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my very first PR on this project, I'm not sure the proper flow to propose changes. Please let me know if I have to open an issue first or whatever. Thanks!
Implementation of a solution for #717: allow to iterate on WiFiManager parameters