Skip to content

Generated rinpop adapter does not compile when there is service extension #210

Open
@chucknthem

Description

service Foo {
   string ping()
}

service Bar extends Foo {
}

The generated code fails with this error:

cannot use adapter (type *RingpopBarAdapter) as type TChanBar in return argument:
	*RingpopBarAdapter does not implement TChanBar (missing Ping method)

Examples of how tchannel-go thrift gen template handles it https://github.com/uber/tchannel-go/blob/dev/thrift/thrift-gen/tchannel-template.go#L55
https://github.com/uber/tchannel-go/blob/dev/thrift/thrift-gen/tchannel-template.go#L45

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions